Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix main CI #4319

Merged
merged 4 commits into from
Mar 5, 2024
Merged

fix: fix main CI #4319

merged 4 commits into from
Mar 5, 2024

Conversation

xxchan
Copy link
Contributor

@xxchan xxchan commented Mar 5, 2024

due to #4311

  • add previous default features to bindings. (except java, nodejs, python. These services already considered the service features) This is to avoid surprise behavior change and also fix CI. can be decided by bindings maintainers later.
  • fix ghac ci by adding feature flag
  • fix oss ci by bumping reqsign
  • enable memory service by default.

@github-actions github-actions bot requested a review from ClSlaid March 5, 2024 07:52
Xuanwo
Xuanwo approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 0d6d866 into apache:main Mar 5, 2024
191 of 192 checks passed
@xxchan
Copy link
Contributor Author

xxchan commented Mar 5, 2024

Oops failed again 😄

@Xuanwo
Copy link
Member

Xuanwo commented Mar 5, 2024

Oops failed again 😄

Only one!

@xxchan
Copy link
Contributor Author

xxchan commented Mar 5, 2024

Is the r2 failure a flaky test?

image

@Xuanwo
Copy link
Member

Xuanwo commented Mar 5, 2024

Is the r2 failure a flaky test?

image

Yep, please ignore it.

@xxchan xxchan mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@oowl oowl Awaiting requested review from oowl oowl is a code owner

@silver-ymz silver-ymz Awaiting requested review from silver-ymz silver-ymz is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xxchan @Xuanwo